Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JENKINS-40155: Fix event's scope deserialization #143

Merged
merged 2 commits into from
Dec 31, 2016
Merged

JENKINS-40155: Fix event's scope deserialization #143

merged 2 commits into from
Dec 31, 2016

Conversation

olivierdagenais
Copy link
Member

The new unit test reproduces JENKINS-40155 and the additions to EventScope fix it. I also sprinkled "scope": "all", in JSON files used as examples and for tests, just to be sure. 😏

@olivierdagenais
Add EventScopeTest skeleton
02df89f
@olivierdagenais
TDD: Event can have a lowercase value for "scope"
35ad535 
JENKINS-40155 reported a failed deserialization due to a case mismatch
in the value of "scope", so added a factory method used by Jackson.
davidstaheli
davidstaheli approved these changes Dec 23, 2016
View reviewed changes
Copy link
Contributor

@davidstaheli davidstaheli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Sir Oli. Thank you!

@olivierdagenais olivierdagenais merged commit b82787a into master Dec 31, 2016
@olivierdagenais olivierdagenais deleted the eventScopeDeserialization branch December 31, 2016 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidstaheli davidstaheli davidstaheli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olivierdagenais @davidstaheli